Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump min required golang to 1.13 #12717

Merged
merged 7 commits into from
Sep 4, 2020
Merged

Bump min required golang to 1.13 #12717

merged 7 commits into from
Sep 4, 2020

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Sep 4, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 4, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 4, 2020
6543
6543 approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its time ...

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 4, 2020
@6543
Copy link
Member

6543 commented Sep 4, 2020

perhaps #12701 is passing then

@silverwind
Copy link
Member

Need to update README.md.

zeripath
zeripath approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min go1.13 for gitea 1.13!

@silverwind
Copy link
Member

Also go-check make target error message.

@techknowlogick techknowlogick merged commit 482b0e6 into master Sep 4, 2020
@techknowlogick techknowlogick deleted the techknowlogick-patch-1 branch September 4, 2020 18:12
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@techknowlogick @6543 @silverwind @zeripath @jolheiser @GiteaBot