Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Show git-pull-request icon for closed pull request #12742

Merged
merged 1 commit into from
Sep 6, 2020

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Sep 6, 2020

As title, I think it's more reasonable, and it's the same as GH.

example view:
image

image

As title, I think it's more reasonable, and it's the same as GH.

Signed-off-by: a1012112796 <1012112796@qq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #12742 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12742      +/-   ##
==========================================
- Coverage   43.40%   43.39%   -0.02%     
==========================================
  Files         648      648              
  Lines       71581    71581              
==========================================
- Hits        31072    31060      -12     
- Misses      35482    35492      +10     
- Partials     5027     5029       +2     
Impacted Files Coverage Δ
modules/notification/mail/mail.go 34.48% <0.00%> (-3.45%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
models/notification.go 66.13% <0.00%> (-0.92%) ⬇️
models/error.go 34.81% <0.00%> (-0.86%) ⬇️
services/pull/pull.go 41.57% <0.00%> (-0.47%) ⬇️
modules/git/repo.go 49.74% <0.00%> (+0.50%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+17.39%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a755e5a...7b1f61a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 6, 2020
@6543 6543 added the topic/ui Change the appearance of the Gitea UI label Sep 6, 2020
@6543 6543 added this to the 1.13.0 milestone Sep 6, 2020
@6543
Copy link
Member

6543 commented Sep 6, 2020

@a1012112796 it's always nice to have screenshots ;)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 6, 2020
@techknowlogick techknowlogick merged commit b613d70 into go-gitea:master Sep 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants