Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whilst changing the character set to utf8mb4 we should set ROW_FORMAT=dynamic too #12804

Merged
merged 5 commits into from
Sep 11, 2020
Merged

Whilst changing the character set to utf8mb4 we should set ROW_FORMAT=dynamic too #12804

merged 5 commits into from
Sep 11, 2020

Conversation

zeripath
Copy link
Contributor

Fix #12801

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Whilst changing the character set to utf8mb4 we should set ROW_FORMAT…
1ddd271 
…=dynamic too

Fix go-gitea#12801

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Sep 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020 •
edited
Loading

Codecov Report

Merging #12804 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12804   +/-   ##
=======================================
  Coverage   43.16%   43.16%           
=======================================
  Files         651      651           
  Lines       72136    72138    +2     
=======================================
+ Hits        31137    31139    +2     
- Misses      35944    35946    +2     
+ Partials     5055     5053    -2
Impacted Files Coverage Δ
models/convert.go 0.00% <0.00%> (ø)
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
services/pull/pull.go 41.57% <0.00%> (-0.47%) ⬇️
modules/git/repo.go 49.74% <0.00%> (+0.50%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
modules/indexer/stats/queue.go 76.47% <0.00%> (+11.76%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+17.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ac1f9...30db918. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2020
@zeripath zeripath merged commit 25c870f into go-gitea:master Sep 11, 2020
@zeripath zeripath deleted the fix-12801-make-convert-do-row-format-dynamic branch September 11, 2020 08:25
@lunny lunny mentioned this pull request Sep 12, 2020
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

gitea convert: alter table ... ROW_FORMAT=dynamic
7 participants
@zeripath @codecov-commenter @silverwind @mrsdizzie @6543 @GiteaBot @lunny