Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable watch and star if not signed in #12807

Merged

Conversation

zeripath
Copy link
Contributor

Fix #12070

Signed-off-by: Andrew Thornton art27@cantab.net

Fix go-gitea#12070

Signed-off-by: Andrew Thornton <art27@cantab.net>
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #12807 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12807      +/-   ##
==========================================
+ Coverage   43.17%   43.21%   +0.03%     
==========================================
  Files         651      651              
  Lines       72145    72145              
==========================================
+ Hits        31151    31174      +23     
+ Misses      35943    35924      -19     
+ Partials     5051     5047       -4     
Impacted Files Coverage Δ
modules/notification/mail/mail.go 34.48% <0.00%> (-3.45%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
models/notification.go 66.13% <0.00%> (-0.92%) ⬇️
models/error.go 35.32% <0.00%> (-0.35%) ⬇️
services/pull/pull.go 42.03% <0.00%> (+0.46%) ⬆️
modules/git/repo.go 49.74% <0.00%> (+0.50%) ⬆️
models/issue_comment.go 54.36% <0.00%> (+0.61%) ⬆️
services/mirror/mirror.go 19.93% <0.00%> (+1.35%) ⬆️
modules/log/event.go 59.43% <0.00%> (+1.88%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ac545...7666308. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 11, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 11, 2020
@zeripath zeripath merged commit 4eb0a1d into go-gitea:master Sep 11, 2020
@zeripath zeripath deleted the fix-12070-hide-subscribe-if-not-signed-in branch September 11, 2020 11:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trying to subscribe to an issue before being logged in leads to a 404 after logging in
6 participants