Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SVG size argument optional #12814

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Make SVG size argument optional #12814

merged 2 commits into from
Sep 11, 2020

Conversation

silverwind
Copy link
Member

Now defaults to 16 on both frontend and backend.

@silverwind
Make SVG size argument optional
8874473 
Now defaults to 16 on both frontend and backend.
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 11, 2020
@lafriks lafriks added this to the 1.14.0 milestone Sep 11, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 11, 2020
@techknowlogick techknowlogick merged commit ffddf3f into go-gitea:master Sep 11, 2020
@lunny lunny modified the milestones: 1.14.0, 1.13.0 Sep 12, 2020
@silverwind silverwind deleted the optional-svg-size branch September 13, 2020 14:56
@silverwind silverwind mentioned this pull request Sep 16, 2020
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
7 participants
@silverwind @lafriks @mrsdizzie @zeripath @lunny @techknowlogick @GiteaBot