Move git update-server-info to hooks #12826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #12826 +/- ##
=======================================
Coverage 42.62% 42.62%
=======================================
Files 672 672
Lines 73785 73784 -1
=======================================
+ Hits 31448 31449 +1
- Misses 37247 37250 +3
+ Partials 5090 5085 -5
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Oct 10, 2020
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #12826 +/- ##
==========================================
+ Coverage 42.41% 42.50% +0.08%
==========================================
Files 673 673
Lines 74114 74113 -1
==========================================
+ Hits 31436 31499 +63
+ Misses 37581 37491 -90
- Partials 5097 5123 +26
Continue to review full report at Codecov.
|
|
But HTTP protocol push will miss that update? |
jolheiser
approved these changes
Oct 13, 2020
GiteaBot
added
lgtm/done
|
techknowlogick
previously requested changes
Oct 13, 2020
|
No it won't - http push always runs the hooks too. This is simply running update-server-info as part of post-receive (the modern equivalent of post-update where it is supposed to be run) |
lafriks
approved these changes
Oct 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #10133 - update-server-info doesn't really belong in the running gitea process but in the hook during its update.
This PR moves this call to the hook directly.
We should consider whether this git method is actually still necessary as
routers/repo/http.go:616:getInfoRefsappears to run this command anyway.Signed-off-by: Andrew Thornton art27@cantab.net