-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: media links in org files not liked to media files #12997
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12997 +/- ##
=======================================
Coverage 42.58% 42.59%
=======================================
Files 671 671
Lines 73625 73632 +7
=======================================
+ Hits 31356 31365 +9
+ Misses 37193 37184 -9
- Partials 5076 5083 +7
Continue to review full report at Codecov.
|
Thanks for the PR - this looks like it would solve the problem - however, as a r is an io.Writer we should just get fmt.Fprintf to write to it directly instead of using the r.WriteString method. |
as suggested by code review Co-authored-by: zeripath <art27@cantab.net>
In Org files, links to images and videos will be linked to "/media/" path, similar to
gitea/modules/markup/markdown/goldmark.go
Lines 87 to 93 in 6a1a633
Fixes #12831