-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Re)Load issue labels when changing them #13007
Merged
lafriks
merged 2 commits into
go-gitea:master
from
zeripath:fix-10660-Ensure-labels-are-loaded-before-webhook
Oct 5, 2020
Merged
(Re)Load issue labels when changing them #13007
lafriks
merged 2 commits into
go-gitea:master
from
zeripath:fix-10660-Ensure-labels-are-loaded-before-webhook
Oct 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Re)Load issue labels when labels are added or removed This means that the label state that the webhooks produce accurately matches the changes that they are reporting. Fix go-gitea#10660 Signed-off-by: Andrew Thornton <art27@cantab.net>
(I have confirmed that this works for the testcase on the associated PR) |
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Oct 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #13007 +/- ##
=======================================
Coverage 42.58% 42.58%
=======================================
Files 671 671
Lines 73632 73644 +12
=======================================
+ Hits 31358 31364 +6
- Misses 37188 37191 +3
- Partials 5086 5089 +3
Continue to review full report at Codecov.
|
lunny
reviewed
Oct 2, 2020
techknowlogick
approved these changes
Oct 5, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Oct 5, 2020
lafriks
approved these changes
Oct 5, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Oct 5, 2020
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Re)Load issue labels when labels are added or removed
This means that the label state that the webhooks produce accurately matches
the changes that they are reporting.
Fix #10660
Signed-off-by: Andrew Thornton art27@cantab.net