-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set appropriate autocomplete
attributes on password fields
#13078
Conversation
`new-password` prevents annoying autocompletion in some cases, thought it's not semantically correct to use that for example on all three fields on the user account page, so some annoyances remain.
I've set this as 1.14 but if it's approved before 1.13 is ready I think it would be reasonable to merge before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All current browsers will still ignore autocomplete="off"
but it will not hurt :)
🚀 |
Codecov Report
@@ Coverage Diff @@
## master #13078 +/- ##
==========================================
- Coverage 42.62% 42.61% -0.02%
==========================================
Files 673 673
Lines 73858 73858
==========================================
- Hits 31482 31474 -8
- Misses 37268 37274 +6
- Partials 5108 5110 +2
Continue to review full report at Codecov.
|
I'm still hoping that some password managers will eventually start to honour it 😉 There's one minor remaining issue on the user account page that my password manager autofills current password so the form will be considered dirty by jquery-are-you sure. Maybe that field can be ignored from dirty check, will have to check later. |
new-password
prevents annoying autocompletion in some cases, thought it's not semantically correct to use that for example on all three fields on the user account page, so some annoyances remain.