Restrict some tables' columns size #14075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CirnoT
suggested changes
Dec 20, 2020
GiteaBot
added
lgtm/need 2
|
Please provide reasoning for why this PR is necessary and why only these specific columns were changed. |
lunny
force-pushed
the
lunny/reaction_col_size
branch
from
6e106c6 to
d2f008e
Compare
I have updated the issue content and explain the reason there. |
lunny
commented
Jan 22, 2021
models/migrations/v163.go
Outdated
| Type string `xorm:"VARCHAR(32) INDEX NOT NULL"` | ||
| OriginalAuthor string `xorm:"VARCHAR(64) INDEX"` | ||
| } | ||
| if err := x.Sync2(new(Reaction)); err != nil { |
There was a problem hiding this comment.
This will not work. Sync2 will only modify columns from small length to big length but not opposite.
lunny
force-pushed
the
lunny/reaction_col_size
branch
from
d2f008e to
f1a8613
Compare
|
Close as too many conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
UPDATE 1:
The default size of a string in XORM is 255, for most things, it's OK.
But for an index, the size will affect the performance.
According this PR,
Typeon reaction table is an index and will be+1,likeand etc. 32 chars is enough for that.OriginalAuthor, LoginName, Name is related with User, in fact, login name have been restricted on
module/auth/user_form.gowhich is40chars. So no reason to use a column with 255 to store that.