Ensure that schema search path is set with every connection on postgres #14131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately every connection to postgres requires that the search path is set appropriately. This PR shadows the postgres driver to ensure that as soon as a connection is open, the search_path is set appropriately. Fix go-gitea#14088 Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
reviewed
Dec 23, 2020
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
approved these changes
Dec 24, 2020
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Jan 2, 2021
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #14131 +/- ##
==========================================
- Coverage 42.01% 41.98% -0.03%
==========================================
Files 734 735 +1
Lines 78773 78803 +30
==========================================
- Hits 33093 33086 -7
- Misses 40245 40276 +31
- Partials 5435 5441 +6
Continue to review full report at Codecov.
|
|
@zeripath Please send backport |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 2, 2021
…es (go-gitea#14131) Backport go-gitea#14131 Unfortunately every connection to postgres requires that the search path is set appropriately. This PR shadows the postgres driver to ensure that as soon as a connection is open, the search_path is set appropriately. Fix go-gitea#14088 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
pushed a commit
that referenced
this pull request
Jan 2, 2021
…es (#14131) (#14216) Backport #14131 Unfortunately every connection to postgres requires that the search path is set appropriately. This PR shadows the postgres driver to ensure that as soon as a connection is open, the search_path is set appropriately. Fix #14088 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately every connection to postgres requires that the search path is
set appropriately.
This PR shadows the postgres driver to ensure that as soon as a connection
is open, the search_path is set appropriately.
Fix #14088
Signed-off-by: Andrew Thornton art27@cantab.net