Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When visit /favicon.ico but the static file is not exist return 404 but not continue to handle the route (#14211) #14213

Merged
merged 1 commit into from
Jan 2, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 2, 2021

backport from #14211

…ut not continue to handle the route (go-gitea#14211)

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@lunny lunny added the type/bug label Jan 2, 2021
@lunny lunny added this to the 1.13.2 milestone Jan 2, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 2, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 2, 2021
@lunny lunny merged commit 17022f8 into go-gitea:release/v1.13 Jan 2, 2021
@lunny lunny deleted the lunny/fix_favicon_redirect2 branch January 2, 2021 10:52
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants