-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All organization members should be assignable as reviewer #14262
All organization members should be assignable as reviewer #14262
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14262 +/- ##
==========================================
+ Coverage 41.98% 42.18% +0.19%
==========================================
Files 760 760
Lines 81199 81203 +4
==========================================
+ Hits 34094 34254 +160
+ Misses 41535 41360 -175
- Partials 5570 5589 +19
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but please fix the comment on line 596 as per https://github.com/go-gitea/gitea/pull/14262/files#r566356479
Since the logic changed, I marked it as a |
From my point of view I wouldn't call this a breaking change. Organization members were already allowed to leave reviews on PRs. This change just makes it possible to explicitly request an organization member's review. |
make lg-tm work |
For PR's in public repos, all organization members should be assignable as reviewer.