Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All organization members should be assignable as reviewer #14262

Merged
merged 18 commits into from
Feb 28, 2021

Conversation

jpraet
Copy link
Member

@jpraet jpraet commented Jan 5, 2021

For PR's in public repos, all organization members should be assignable as reviewer.

models/repo.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 5, 2021
@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #14262 (88a90e3) into master (154b23d) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14262      +/-   ##
==========================================
+ Coverage   41.98%   42.18%   +0.19%     
==========================================
  Files         760      760              
  Lines       81199    81203       +4     
==========================================
+ Hits        34094    34254     +160     
+ Misses      41535    41360     -175     
- Partials     5570     5589      +19     
Impacted Files Coverage Δ
modules/base/tool.go 94.25% <ø> (+19.61%) ⬆️
models/repo.go 52.57% <100.00%> (+0.16%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/repo_mirror.go 16.66% <0.00%> (-11.91%) ⬇️
modules/git/repo_base_nogogit.go 63.63% <0.00%> (-9.10%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-6.75%) ⬇️
services/pull/check.go 48.52% <0.00%> (-2.95%) ⬇️
modules/cron/tasks_basic.go 85.43% <0.00%> (-2.92%) ⬇️
modules/git/utils.go 77.77% <0.00%> (-2.78%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b7af6...88a90e3. Read the comment docs.

models/repo.go Outdated Show resolved Hide resolved
@6543 6543 added the type/enhancement An improvement of existing functionality label Jan 23, 2021
models/repo.go Show resolved Hide resolved
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but please fix the comment on line 596 as per https://github.com/go-gitea/gitea/pull/14262/files#r566356479

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2021
@lunny lunny added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Feb 2, 2021
@lunny
Copy link
Member

lunny commented Feb 2, 2021

Since the logic changed, I marked it as a break change.

@jpraet
Copy link
Member Author

jpraet commented Feb 16, 2021

From my point of view I wouldn't call this a breaking change. Organization members were already allowed to leave reviews on PRs. This change just makes it possible to explicitly request an organization member's review.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2021
@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit 3e65286 into go-gitea:master Feb 28, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants