Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if label template exist first #14384

Merged
merged 5 commits into from
Jan 18, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 18, 2021

fix #14327

and other possible db-deadlocks with SQLite

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 18, 2021
models/repo.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Jan 18, 2021

ok this resolve the DB deadlock for sqlite without the check, but I'll leave the check in since if it will fail anyway why not check it before touching DB at all ...

@6543 6543 marked this pull request as ready for review January 18, 2021 16:57
@6543 6543 added this to the 1.14.0 milestone Jan 18, 2021
models/repo.go Outdated Show resolved Hide resolved
@6543 6543 added the backport/done All backports for this PR have been created label Jan 18, 2021
@codecov-io
Copy link

Codecov Report

Merging #14384 (0f52aa8) into master (127907c) will decrease coverage by 0.00%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14384      +/-   ##
==========================================
- Coverage   41.84%   41.84%   -0.01%     
==========================================
  Files         744      744              
  Lines       79738    79741       +3     
==========================================
- Hits        33366    33365       -1     
- Misses      40861    40864       +3     
- Partials     5511     5512       +1     
Impacted Files Coverage Δ
models/issue_label.go 67.15% <0.00%> (ø)
modules/structs/repo.go 60.00% <ø> (ø)
modules/repository/create.go 46.96% <7.69%> (-3.88%) ⬇️
models/repo.go 52.32% <55.55%> (+0.17%) ⬆️
modules/git/repo_base_nogogit.go 63.63% <0.00%> (-9.10%) ⬇️
modules/git/utils.go 77.77% <0.00%> (-2.78%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 127907c...0f52aa8. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 18, 2021
@6543 6543 merged commit 2686e6b into go-gitea:master Jan 18, 2021
@6543 6543 deleted the check-if-label-template-exist-first branch January 18, 2021 20:00
6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 18, 2021
* add check

* refactor

* rollback repo on error after session closed
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 19, 2021
* master: (27 commits)
  Use path not filepath in routers/editor (go-gitea#14390)
  Display error if twofaSecret cannot be retrieved (go-gitea#14372)
  Check if label template exist first (go-gitea#14384)
  Allow passcode invalid error to appear (go-gitea#14371)
  exclude authored PRs from Review Requested filter (go-gitea#14368)
  Upgrade blevesearch dependency to v2.0.1 (go-gitea#14346)
  Implement ghost comment mitigation (go-gitea#14349)
  Add edit, delete and reaction support to code review comments on issue page (go-gitea#14339)
  Add review requested filter on pull request overview (go-gitea#13701)
  escape branch names in compare url (go-gitea#14364)
  label and milestone webhooks on issue/pull creation (go-gitea#14363)
  Fix middlewares sequences (go-gitea#14354)
  Sort issue search results by revelance (go-gitea#14353)
  KanBan: be able to set default board (go-gitea#14147)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: create repo with invalid label set hangs gitea
5 participants