Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-receive hook to check for email privacy #14686

Closed
wants to merge 1 commit into from

Conversation

jolheiser
Copy link
Member

This PR aims to help keep email private for those users who wish to do so.

It adds a check in pre-receive that checks incoming commits and checks if the commit author email matches the user committing.
If it matches any email and the user has indicated they want their email to remain private, the hook fails, telling them why.

This PR also adds a message to the user profile where they set their email privacy, letting them know what their noreply alternative is.

Now, a few questions and why this is a draft...


  1. Wording. I'm not a huge fan of the wording I've chosen, and I would like feedback.
  2. Should a push option be added so a user can force the commit through, rather than making them open the web UI to change their privacy?
  3. Currently this only checks commit author. Should it also check committer?

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added the type/enhancement An improvement of existing functionality label Feb 15, 2021
@jolheiser jolheiser added this to the 1.15.0 milestone Feb 15, 2021
@zeripath zeripath modified the milestones: 1.15.0, 1.16.0 Jun 23, 2021
@zeripath
Copy link
Contributor

Moving to 1.16 as not ready. Feel free to move back to 1.15 if ready.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 23, 2021
@jolheiser jolheiser mentioned this pull request Jul 14, 2021
@lunny lunny removed this from the 1.16.0 milestone Nov 9, 2021
@yardenshoham
Copy link
Member

This is in progress for a while now, I'm closing it to avoid stale pull requests. Please reopen when it's ready for review.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants