-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Add max concurrent hashes setting #14713
Conversation
Simplest solution is to map all the functions on to the Request directly Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Related #14702 |
Signed-off-by: Andrew Thornton <art27@cantab.net>
… into add-max-concurrent-hashes
Signed-off-by: Andrew Thornton <art27@cantab.net>
conflicts resolved |
Codecov Report
@@ Coverage Diff @@
## main #14713 +/- ##
==========================================
- Coverage 44.07% 44.04% -0.04%
==========================================
Files 682 682
Lines 82408 82457 +49
==========================================
- Hits 36322 36317 -5
- Misses 40176 40233 +57
+ Partials 5910 5907 -3
Continue to review full report at Codecov.
|
do you have time to resolve the conflicts? |
conflicts resolved |
Some hash algorithms can be very costly to generate. This PR adds a setting to limit the maximum concurrent hashes performed at any one time.