Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add max concurrent hashes setting #14713

Closed
wants to merge 15 commits into from

Conversation

zeripath
Copy link
Contributor

Some hash algorithms can be very costly to generate. This PR adds a setting to limit the maximum concurrent hashes performed at any one time.

Simplest solution is to map all the functions on to the Request directly

Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Copy link
Contributor Author

Related #14702

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2021
@zeripath
Copy link
Contributor Author

zeripath commented May 9, 2021

conflicts resolved

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #14713 (76d117f) into main (6021fbf) will decrease coverage by 0.03%.
The diff coverage is 30.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14713      +/-   ##
==========================================
- Coverage   44.07%   44.04%   -0.04%     
==========================================
  Files         682      682              
  Lines       82408    82457      +49     
==========================================
- Hits        36322    36317       -5     
- Misses      40176    40233      +57     
+ Partials     5910     5907       -3     
Impacted Files Coverage Δ
cmd/admin.go 0.00% <0.00%> (ø)
modules/auth/sso/reverseproxy.go 8.51% <0.00%> (ø)
routers/events/events.go 0.00% <0.00%> (ø)
routers/install.go 0.00% <0.00%> (ø)
routers/private/manager.go 0.00% <0.00%> (ø)
routers/repo/blame.go 0.00% <0.00%> (ø)
routers/user/auth_openid.go 0.00% <0.00%> (ø)
services/archiver/archiver.go 72.78% <0.00%> (ø)
models/user.go 51.19% <21.42%> (-1.96%) ⬇️
routers/user/auth.go 12.30% <25.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6021fbf...76d117f. Read the comment docs.

@zeripath zeripath mentioned this pull request May 9, 2021
12 tasks
@6543
Copy link
Member

6543 commented May 20, 2021

do you have time to resolve the conflicts?

@zeripath
Copy link
Contributor Author

conflicts resolved

@zeripath zeripath closed this May 7, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants