Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create admin auths API #14808

Closed
wants to merge 4 commits into from
Closed

Create admin auths API #14808

wants to merge 4 commits into from

Conversation

daniil-pankratov
Copy link
Contributor

This PR adds new admin auths API endpoints: one - for getting list of existing authentication sources with their configuration and another one - to create new authentication source.

@6543 6543 added modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Feb 26, 2021
@6543 6543 added this to the 1.15.0 milestone Feb 26, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2021
@lunny
Copy link
Member

lunny commented Apr 23, 2021

Some config may contains secrets which should not be expose?

@techknowlogick techknowlogick modified the milestones: 1.15.0, 1.16.0 Jun 23, 2021
@lunny lunny modified the milestones: 1.16.0, 1.17.0 Nov 9, 2021
@lunny lunny modified the milestones: 1.17.0, 1.18.0 Jun 3, 2022
@lunny lunny removed this from the 1.18.0 milestone Oct 17, 2022
This was referenced Feb 6, 2023
Closed
Draft
@yardenshoham
Copy link
Member

Is this PR stale?

@yardenshoham yardenshoham added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label May 9, 2023
@wxiaoguang
Copy link
Contributor

I guess there could be some obstacles for this PR at the moment (just a guess):

  1. security concern (might be resolved by scoped token / privileged token)
  2. API stability: Gitea's auth system has too many technical debts, exposing these auth sources directly seems not be able to be stable. I can foresee that Gitea's auth system needs to be refactored in near future to support: hide local login/set default login/2FA policy, etc.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 left review comments

Assignees
No one assigned
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@daniil-pankratov @lunny @yardenshoham @wxiaoguang @6543 @techknowlogick @GiteaBot