Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Fix how lfs data path is set #14855

Merged
merged 8 commits into from
Mar 4, 2021
Merged

[Docs] Fix how lfs data path is set #14855

merged 8 commits into from
Mar 4, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 2, 2021 •
edited
Loading

inconsistency was introduced in #12813 & #12988

@6543 6543 added type/bug type/docs This PR mainly updates/creates documentation backport/v1.13 labels Mar 2, 2021
@noerw
Copy link
Member

noerw commented Mar 3, 2021

Shouldnt one of [server] LFS_CONTENT_PATH & [lfs] PATH be deprecated (+ undocumented) instead of having two keys for the same thing?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2021
6543
6543 commented Mar 4, 2021
View reviewed changes
Copy link
Member Author

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, think it's ready to look at again :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2021
@6543
Copy link
Member Author

6543 commented Mar 4, 2021

🚀

@6543 6543 merged commit 8ac1367 into go-gitea:master Mar 4, 2021
@6543 6543 deleted the docs_lfs-content branch March 4, 2021 17:01
6543 added a commit to 6543-forks/gitea that referenced this pull request Mar 4, 2021
@6543 @techknowlogick @lunny
[Docs] Fix how lfs data path is set (go-gitea#14855)
1ee3d0e 
* fix docs: lfs data path

* DEPRECATED note

* 已废弃

* better english sentence

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@6543 6543 mentioned this pull request Mar 4, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Mar 4, 2021
6543 added a commit that referenced this pull request Mar 4, 2021
@6543 @techknowlogick @lunny
[Docs] Fix how lfs data path is set (#14855) (#14884)
8456700 
* fix docs: lfs data path

* DEPRECATED | 已废弃

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noerw noerw noerw approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @noerw @lunny @GiteaBot @techknowlogick