Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] mailer service #15072

Merged
merged 31 commits into from
Apr 2, 2021
Merged

[refactor] mailer service #15072

merged 31 commits into from
Apr 2, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 20, 2021 •
edited
Loading

work on #14822

  • unexport internal functions
  • pass user to mail functions
  • create internal mail functions witch are triggered by language group
  • localize mail subjects
  • localize mail templates -> next pull :)

@6543 6543 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Mar 20, 2021
@6543 6543 added this to the 1.15.0 milestone Mar 20, 2021
6543
6543 commented Mar 20, 2021
View reviewed changes
services/mailer/mail.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 20, 2021
6543
6543 commented Mar 20, 2021
View reviewed changes
routers/user/auth_openid.go Outdated Show resolved Hide resolved
6543
6543 commented Mar 20, 2021
View reviewed changes
routers/user/setting/account.go Outdated Show resolved Hide resolved
6543
6543 commented Apr 1, 2021
View reviewed changes
services/mailer/mail.go Outdated Show resolved Hide resolved
@6543 6543 removed the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Apr 1, 2021
zeripath
zeripath reviewed Apr 1, 2021
View reviewed changes
services/mailer/mail.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Apr 1, 2021
View reviewed changes
services/mailer/mail.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Apr 1, 2021

Both solutions for i18n templates works ... both have there pro&cons ... for gitea admins & us maintainer ...

zeripath and others added 3 commits April 1, 2021 21:08
@zeripath
improve mailIssueCommentBatch
291d0e9 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@6543
Merge branch 'master' into refactor_mailer
cd80b9c
@zeripath
add i18n to datas
9b527c8 
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
zeripath approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be beneficial to just do the heavy lifting of moving the translations in this PR but I think adding the framework here is enough.

LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 1, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 2, 2021
@zeripath
Copy link
Contributor

zeripath commented Apr 2, 2021

Make lgtm work

@zeripath zeripath merged commit 80d6c6d into go-gitea:master Apr 2, 2021
@6543 6543 deleted the refactor_mailer branch April 2, 2021 13:20
@6543 6543 mentioned this pull request Apr 3, 2021
Merged
3 tasks
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @zeripath @lunny @GiteaBot