fix some ui bug about draft release

[a1012112796]

• should not show draft release in tag list because
  it will't create real tag
• still show draft release without tag and commit message
  for draft release instead of 404 error
• remove tag load for attachement links because it's useless

fix #15058

[tomaswarynyca]

@a1012112796 Please resolve the conflicts.

[a1012112796]

waiting review

[codecov-commenter]

Codecov Report

Merging #15137 (538c152) into main (eedc0c8) will increase coverage by 0.00%.
The diff coverage is 40.00%.

@@           Coverage Diff           @@
##             main   #15137   +/-   ##
=======================================
  Coverage   43.95%   43.96%           
=======================================
  Files         678      678           
  Lines       81903    81908    +5     
=======================================
+ Hits        36000    36010   +10     
  Misses      40027    40027           
+ Partials     5876     5871    -5     

Impacted Files	Coverage Δ
routers/repo/release.go	26.58% <30.00%> (+2.19%)	⬆️
modules/context/repo.go	53.12% <33.33%> (-0.20%)	⬇️
routers/routes/web.go	86.47% <100.00%> (ø)
modules/notification/mail/mail.go	38.77% <0.00%> (-3.07%)	⬇️
modules/queue/manager.go	61.36% <0.00%> (-2.85%)	⬇️
modules/process/manager.go	72.83% <0.00%> (-2.47%)	⬇️
routers/api/v1/repo/pull.go	28.14% <0.00%> (-0.60%)	⬇️
models/repo_list.go	77.82% <0.00%> (+0.77%)	⬆️
services/pull/patch.go	55.93% <0.00%> (+1.69%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eedc0c8...538c152. Read the comment docs.

[lunny]

Could you add some tests?

[a1012112796]

Could you add some tests?

done

[lunny]

Could you add some tests?

done

CI failed.

[richmahn]

@a1012112796 Doing a review for you today

[richmahn]

@a1012112796 Before I dig in, does this get drafts working like Github handles drafts for releases? I noticed just last week that GitHub does it different:

1. doesn't require a tag
2. if you do specify a tag it will lock the release to that commit ID even if the target branch head changes (i.e. makes the tag, but hides the release)

[a1012112796]

@a1012112796 Before I dig in, does this get drafts working like Github handles drafts for releases? I noticed just last week that GitHub does it different:

1. doesn't require a tag
2. if you do specify a tag it will lock the release to that commit ID even if the target branch head changes (i.e. makes the tag, but hides the release)

yes, in gitea curent design, it willn't create tag in git repository for a draft release. so any link about git tag is not useable for a draft release. and it's also not correct to show draft release on tags list.

[richmahn]

@a1012112796 I noticed it still requires a tag if it is a draft. Github doesn't require that to be filled for a draft so that you can go back and tag it later (maybe want to set up the release info but developers/qa might still be trying to get a few more commits in). Is that outside the scope of this PR? #7693

[richmahn]

@a1012112796 Wow, already has conflicts again.

[richmahn]

For what it's worth, it looks like GitHub still locks the Draft to the commit ID of target at the time the draft is made, assigning a temporary tag to the draft release, and renaming it when the actual release is made, so probably useful in that you don't want the draft tag showing up in the list of tags for the repo.

[richmahn]

LGTM, just fix conflicts.

[richmahn]

@lafriks Needs your approval again.