Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose resolver via API #15167

Merged
merged 3 commits into from
Mar 27, 2021
Merged

Expose resolver via API #15167

merged 3 commits into from
Mar 27, 2021

Commits on Mar 26, 2021

  1. Expose resolver via API 

    * Add a new field to the API to expose the "resolver" of a comment/
  conversation. This is not available in the GitHub API v3.
* Extend struct to contain "Resolver". Might be empty (nil).
* Rename "Reviewer" to "Poster" in PullReviewComment to make it
  clear this is the person posting a comment. The API is unchanged
  ('user').
* Only the first comment of a conversation might have a resolver,
  the others seem to be always nil.
    @sotho
    sotho committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    5583c03 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2021

  1. Merge branch 'master' into expose-resolver

    @zeripath
    zeripath committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    708d7c7 View commit details
    Browse the repository at this point in the history

  2. placate lint 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    7c4c982 View commit details
    Browse the repository at this point in the history