Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up enry.IsVendor (#15213) #15245

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 1, 2021

Backport #15213

enry.IsVendor is kinda slow as it simply iterates across all regexps.
This PR ajdusts the regexps to combine them to make this process a
little quicker.

Related #15143

Signed-off-by: Andrew Thornton art27@cantab.net

Backport go-gitea#15213

`enry.IsVendor` is kinda slow as it simply iterates across all regexps.
This PR ajdusts the regexps to combine them to make this process a
little quicker.

Related go-gitea#15143

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the performance/speed performance issues with slow downs label Apr 1, 2021
@zeripath zeripath added this to the 1.14.0 milestone Apr 1, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 1, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 1, 2021
@6543
Copy link
Member

6543 commented Apr 1, 2021

🚀

@6543 6543 merged commit f75a9b2 into go-gitea:release/v1.14 Apr 1, 2021
@zeripath zeripath deleted the backport-15213-v1.14 branch April 2, 2021 03:28
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/speed performance issues with slow downs skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants