Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of some JS globals #15378

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Conversation

silverwind
Copy link
Member

Refactor the exported globals in index.js to JS-initialized event handlers.

Refactor the exported globals in index.js to JS-initialized event
handlers.
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 9, 2021
@silverwind silverwind added this to the 1.15.0 milestone Apr 9, 2021
@silverwind silverwind changed the title Remove usage of JS globals Remove usage of some JS globals Apr 9, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 9, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 9, 2021
@techknowlogick techknowlogick merged commit 2169762 into go-gitea:master Apr 9, 2021
@silverwind silverwind deleted the rmexports branch April 10, 2021 07:32
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants