Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed several activation bugs #15473

Merged
merged 8 commits into from
Apr 30, 2021
Merged

Fixed several activation bugs #15473

merged 8 commits into from
Apr 30, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Apr 14, 2021

  • Fixed invalid form tag
  • Fixed NPE on GET /user/activate

@zeripath
Copy link
Contributor

I think we also need to ensure that we only validate passwords on POST in this function.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 14, 2021
@zeripath
Copy link
Contributor

See:

gitea/routers/routes/web.go

Line 473 in 08ba895

m.Any("/activate", user.Activate, reqSignIn)

@KN4CK3R KN4CK3R mentioned this pull request Apr 14, 2021
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2021
@6543 6543 merged commit 7670c1c into go-gitea:master Apr 30, 2021
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Apr 30, 2021
@KN4CK3R @6543
Fixed several activation bugs (go-gitea#15473)
fad6cb4 
* Removed unneeded form tag.

* Fixed typo.

* Fixed NPE.

* Use better error page.

* Splitted GET and POST.
@6543 6543 mentioned this pull request Apr 30, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Apr 30, 2021
techknowlogick pushed a commit that referenced this pull request May 1, 2021
@6543 @KN4CK3R
Fixed several activation bugs (#15473) (#15685)
15886ce 
* Removed unneeded form tag.

* Fixed typo.

* Fixed NPE.

* Use better error page.

* Splitted GET and POST.

Co-authored-by: KN4CK3R <KN4CK3R@users.noreply.github.com>
@KN4CK3R KN4CK3R deleted the fix-activation branch May 7, 2021 06:31
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KN4CK3R @zeripath @6543 @GiteaBot