Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use boost workers for leveldb shadow queues #15696

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 1, 2021

The leveldb shadow queue of a persistable channel queue should always start with 0
workers and just use boost to add additional workers if necessary.

Fixes #15542

Signed-off-by: Andrew Thornton art27@cantab.net

The leveldb shadow queue of a persistable channel queue should always start with 0
workers and just use boost to add additional workers if necessary.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the type/enhancement An improvement of existing functionality label May 1, 2021
@zeripath zeripath added this to the 1.15.0 milestone May 1, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 1, 2021
… to start the workers

Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #15696 (a6682bd) into master (6ebd833) will decrease coverage by 0.01%.
The diff coverage is 71.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15696      +/-   ##
==========================================
- Coverage   43.91%   43.89%   -0.02%     
==========================================
  Files         678      678              
  Lines       81838    81866      +28     
==========================================
  Hits        35936    35936              
- Misses      40052    40083      +31     
+ Partials     5850     5847       -3     
Impacted Files Coverage Δ
modules/queue/workerpool.go 51.64% <63.33%> (-7.13%) ⬇️
modules/queue/queue_disk_channel.go 70.77% <100.00%> (ø)
modules/queue/unique_queue_disk_channel.go 55.22% <100.00%> (ø)
services/pull/pull.go 43.47% <0.00%> (ø)
models/gpg_key.go 54.07% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebd833...a6682bd. Read the comment docs.

@zeripath
Copy link
Contributor Author

zeripath commented May 1, 2021

This also fixes the timeout times reported on the process manager for boost workers and also makes it possible to start all queues with zero workers to allow defaulting to boost when they get some work.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2021
@6543 6543 self-requested a review May 2, 2021 01:16
@zeripath zeripath merged commit 0590176 into go-gitea:master May 2, 2021
@zeripath zeripath deleted the only-use-temporary-workers-for-persistable-level-queues branch May 2, 2021 07:22
@zeripath zeripath mentioned this pull request May 9, 2021
12 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants