Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Light Chroma style #15699

Merged
merged 4 commits into from
May 3, 2021
Merged

Improve Light Chroma style #15699

merged 4 commits into from
May 3, 2021

Conversation

mlpo
Copy link
Contributor

@mlpo mlpo commented May 2, 2021

The colors used for strings by the Light Chroma style did not stand out well from the rest of the code (colored in dark gray by default).

Specifically, the changes are:

  • Default string color: #032f62 → #106303 (from a very dark blue to a dark green)
  • Single-quoted string color: #24292e → #cc7a00 (from a very dark blue to a dark sand yellow)

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2021

Codecov Report

Merging #15699 (247d2d6) into master (0590176) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15699   +/-   ##
=======================================
  Coverage   43.89%   43.89%           
=======================================
  Files         678      678           
  Lines       81866    81866           
=======================================
+ Hits        35933    35938    +5     
+ Misses      40084    40083    -1     
+ Partials     5849     5845    -4     
Impacted Files Coverage Δ
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/log/file.go 75.39% <0.00%> (+1.58%) ⬆️
modules/process/manager.go 75.30% <0.00%> (+2.46%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0590176...247d2d6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 2, 2021
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels May 2, 2021
@techknowlogick techknowlogick added this to the 1.15.0 milestone May 2, 2021
@techknowlogick
Copy link
Member

Thanks for your PR :) Are you able to provide screenshots of the before/after of your changes?

@mlpo
Copy link
Contributor Author

mlpo commented May 2, 2021

After several tests to have colors that are not too close, while maintaining a uniform style, I finally selected a dark green and a dark sand yellow.

@techknowlogick here before and after screenshots (click to zoom):

Before After
Before screenshot After screenshot

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 5c5cfd6 into go-gitea:master May 3, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants