-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Light Chroma style #15699
Improve Light Chroma style #15699
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15699 +/- ##
=======================================
Coverage 43.89% 43.89%
=======================================
Files 678 678
Lines 81866 81866
=======================================
+ Hits 35933 35938 +5
+ Misses 40084 40083 -1
+ Partials 5849 5845 -4
Continue to review full report at Codecov.
|
Thanks for your PR :) Are you able to provide screenshots of the before/after of your changes? |
After several tests to have colors that are not too close, while maintaining a uniform style, I finally selected a dark green and a dark sand yellow. @techknowlogick here before and after screenshots (click to zoom):
|
🚀 |
The colors used for strings by the
Light
Chroma style did not stand out well from the rest of the code (colored in dark gray by default).Specifically, the changes are: