Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] make change repo settings work on empty repos #15778

Merged
merged 5 commits into from
May 8, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented May 7, 2021

close #15602

@6543 6543 added type/bug modifies/api This PR adds API routes or modifies them backport/v1.14 labels May 7, 2021
@6543 6543 added this to the 1.15.0 milestone May 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15778 (b2956c7) into main (272bbb2) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15778      +/-   ##
==========================================
- Coverage   43.96%   43.95%   -0.01%     
==========================================
  Files         678      678              
  Lines       81999    81998       -1     
==========================================
- Hits        36048    36043       -5     
- Misses      40076    40077       +1     
- Partials     5875     5878       +3     
Impacted Files Coverage Δ
routers/api/v1/repo/repo.go 57.99% <14.28%> (-0.34%) ⬇️
routers/api/v1/api.go 78.15% <100.00%> (ø)
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/queue/workerpool.go 51.64% <0.00%> (-1.10%) ⬇️
routers/repo/view.go 40.66% <0.00%> (-0.59%) ⬇️
services/pull/pull.go 43.83% <0.00%> (+0.45%) ⬆️
modules/notification/mail/mail.go 41.83% <0.00%> (+3.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272bbb2...b2956c7. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 8, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 8, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 8, 2021
@6543 6543 merged commit e278614 into go-gitea:main May 8, 2021
@6543 6543 deleted the fix-15602_PATCH-repo branch May 8, 2021 12:11
6543 added a commit to 6543-forks/gitea that referenced this pull request May 8, 2021
@6543
Copy link
Member Author

6543 commented May 8, 2021

-> #15789

@6543 6543 added the backport/done All backports for this PR have been created label May 8, 2021
6543 added a commit that referenced this pull request May 8, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: PATCH api/v1/repos/{username}/{reponame} does not work when repo is empty
5 participants