Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second attempt at preventing zombies #16326

Merged
merged 13 commits into from
Jul 14, 2021
Merged

Second attempt at preventing zombies #16326

merged 13 commits into from
Jul 14, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jul 1, 2021

  • Ensure that the pipes are closed in ssh.go
  • Ensure that a cancellable context is passed up in cmd/* http requests
  • Make cmd.fail return properly so defers are obeyed
  • Ensure that something is sent to stdout in case of blocks here

Follow-up #16314

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Second attempt at preventing zombies
f2056a0 
* Ensure that the pipes are closed in ssh.go
* Ensure that a cancellable context is passed up in cmd/* http requests
* Make cmd.fail return properly so defers are obeyed
* Ensure that something is sent to stdout in case of blocks here

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 1, 2021
@zeripath zeripath added this to the 1.15.0 milestone Jul 1, 2021
@zeripath
placate lint
6ef4968 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
placate lint 2
a26c61f 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
placate lint 3
22f358d 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Merge branch 'main' into zombie-two
078176f
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 2, 2021
a1012112796
a1012112796 reviewed Jul 2, 2021
View reviewed changes
cmd/serv.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021 •
edited
Loading

Codecov Report

Merging #16326 (07e3c3c) into main (0393a57) will increase coverage by 1.18%.
The diff coverage is 47.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16326      +/-   ##
==========================================
+ Coverage   44.24%   45.42%   +1.18%     
==========================================
  Files         695      717      +22     
  Lines       82341    84162    +1821     
==========================================
+ Hits        36429    38234    +1805     
+ Misses      40014    39780     -234     
- Partials     5898     6148     +250
Impacted Files Coverage Δ
cmd/convert.go 0.00% <0.00%> (ø)
cmd/dump.go 0.91% <0.00%> (ø)
cmd/dump_repo.go 0.00% <0.00%> (ø)
cmd/generate.go 0.00% <0.00%> (ø)
cmd/hook.go 0.00% <0.00%> (ø)
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/migrate.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 0.00% <0.00%> (ø)
cmd/restore_repo.go 0.00% <0.00%> (ø)
... and 315 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ead8ce...07e3c3c. Read the comment docs.

@zeripath
Copy link
Contributor Author

Please can this get some reviews as it's holding up 1.15 now

6543
6543 reviewed Jul 14, 2021
View reviewed changes
cmd/serv.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 14, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 14, 2021
@lafriks
Copy link
Member

lafriks commented Jul 14, 2021

🚀

@techknowlogick techknowlogick merged commit 3dcb3e9 into go-gitea:main Jul 14, 2021
@zeripath zeripath deleted the zombie-two branch July 14, 2021 14:49
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@zeripath @6543
@lafriks @AbdulrhmnGhanem
Second attempt at preventing zombies (go-gitea#16326)
ae237c6 
* Second attempt at preventing zombies

* Ensure that the pipes are closed in ssh.go
* Ensure that a cancellable context is passed up in cmd/* http requests
* Make cmd.fail return properly so defers are obeyed
* Ensure that something is sent to stdout in case of blocks here

Signed-off-by: Andrew Thornton <art27@cantab.net>

* placate lint

Signed-off-by: Andrew Thornton <art27@cantab.net>

* placate lint 2

Signed-off-by: Andrew Thornton <art27@cantab.net>

* placate lint 3

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fixup

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Apply suggestions from code review

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a1012112796 a1012112796 a1012112796 left review comments

@6543 6543 6543 approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@zeripath @codecov-commenter @lafriks @6543 @a1012112796 @techknowlogick @GiteaBot