-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix calculation for finalPage in repo-search component #16357
Closed
jannaahs
wants to merge
7
commits into
go-gitea:main
from
jannaahs:fix/too-many-pages-on-repo-paging-in-dashboard
Closed
fix calculation for finalPage in repo-search component #16357
jannaahs
wants to merge
7
commits into
go-gitea:main
from
jannaahs:fix/too-many-pages-on-repo-paging-in-dashboard
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpraet
approved these changes
Jul 7, 2021
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Jul 7, 2021
6543
approved these changes
Jul 8, 2021
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jul 8, 2021
lafriks
approved these changes
Jul 9, 2021
6543
force-pushed
the
fix/too-many-pages-on-repo-paging-in-dashboard
branch
from
July 9, 2021 03:10
19b0f34
to
f03779f
Compare
rebased ... let's see if it pass now? |
@techknowlogick do a force merge? since same diff passed at #16382 ? |
noerw
approved these changes
Jul 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
finalPage
was calculated incorrectly in the repo-search component. This caused an empty unnecessary page to be added as described in #15601.OLD
This calculation will round down the number of pages and increment.
NEW
This calculation will always round up the number of pages, if it's not an integer
This pull request will fix #15601.