Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in log #16490

Merged
merged 7 commits into from
Jul 20, 2021
Merged

Fix race in log #16490

merged 7 commits into from
Jul 20, 2021

Commits on Jul 19, 2021

  1. Fix race in log 

    A race has been detected in go-gitea#1441 relating to getting log levels.

This PR protects the GetLevel and GetStacktraceLevel calls with a mutex.

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    a7fe58b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Merge remote-tracking branch 'origin/main' into fix-race-in-log

    @zeripath
    zeripath committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    4e652ad View commit details
    Browse the repository at this point in the history

  2. use rwmutex as per lafriks 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1a34d0a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix-race-in-log

    @zeripath
    zeripath authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    e7e6be8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix-race-in-log

    @lafriks
    lafriks authored Jul 20, 2021
    Configuration menu
    Copy the full SHA
    97b1161 View commit details
    Browse the repository at this point in the history

  5. Remove assertion of batch length as there is no non-racey 

    way to run that test

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    6bb4440 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'fix-race-in-log' of github.com:zeripath/gitea into fix-… 

    …race-in-log
    @zeripath
    zeripath committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    91f086a View commit details
    Browse the repository at this point in the history