Fix session bugs #16552
Merged
Fix session bugs #16552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
reviewed
Jul 26, 2021
GiteaBot
added
the
lgtm/need 2
Co-authored-by: zeripath <art27@cantab.net>
zeripath
approved these changes
Jul 26, 2021
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jul 26, 2021
GiteaBot
added
lgtm/done
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Jul 26, 2021
* fix deadlog bug * Fix models/issue_stopwatch.go * Update models/issue_stopwatch.go Co-authored-by: zeripath <art27@cantab.net>
|
-> #16553 |
|
The bug is that no database transaction when create stop watch or cancel so that it may be non-consistent. |
lunny
pushed a commit
that referenced
this pull request
Jul 27, 2021
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
* fix deadlog bug * Fix models/issue_stopwatch.go * Update models/issue_stopwatch.go Co-authored-by: zeripath <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while working on #16551 I found some session bugs at models