-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ctx.Form() to ctx.FormString() and move code into own file #16571
Rename ctx.Form() to ctx.FormString() and move code into own file #16571
Conversation
I don't understand the reasoning behind renaming form to formstring. It appears to make it inconsistent with the way we use Query and with ini. Is the intention that form will return the form in the future? |
@zeripath the problem is that to the form thing ... it's golang specific - i personaly also prevere to use the term query ... but net/http do differ between GET and POST, ... requests - Query only apply to get where Form do the same and apply to all request types |
Codecov Report
@@ Coverage Diff @@
## main #16571 +/- ##
==========================================
+ Coverage 45.38% 45.39% +0.01%
==========================================
Files 757 757
Lines 85194 85092 -102
==========================================
- Hits 38664 38630 -34
+ Misses 40273 40205 -68
Partials 6257 6257
Continue to review full report at Codecov.
|
Co-authored-by: zeripath <art27@cantab.net>
@zeripath can you |
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath I'll merge this for now, if we like to go a interface way as you proposed ... I'm happy to review your pull etc. For now I think this is god to go and we can move things forward ... (It's already cleaner this way & rm useless code) |
Followup from #16562 prepare for #16567