fix can't push git notes bug

[a1012112796]

Not sure can f-i-x #16688, Because this nit will't cause crash bug.

[codecov-commenter]

Codecov Report

Merging #16689 (71b3384) into main (23a87a0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #16689   +/-   ##
=======================================
  Coverage   45.39%   45.40%           
=======================================
  Files         758      758           
  Lines       85306    85308    +2     
=======================================
+ Hits        38727    38735    +8     
+ Misses      40298    40294    -4     
+ Partials     6281     6279    -2     

Impacted Files	Coverage Δ
routers/private/hook.go	34.31% <0.00%> (-0.14%)	⬇️
modules/queue/workerpool.go	55.34% <0.00%> (+0.38%)	⬆️
models/repo_list.go	78.43% <0.00%> (+0.78%)	⬆️
modules/process/manager.go	75.30% <0.00%> (+2.46%)	⬆️
modules/util/timer.go	85.71% <0.00%> (+42.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf9f41...71b3384. Read the comment docs.

[zeripath]

Whilst I agree that this would fix the problem, the function HookPreReceive is a total mess right now.

Adding yet another else if block to that sprawling if else inside a for loop isn't going to improve things.

It needs a more substantial refactor. The code inside the if blocks needs to be farmed out to functions and the duplication related to the proc receive needs to be refactored away.

The internal server error return is incorrect as it should be a forbidden. But we need to think more carefully about which refs we're disallowing e.g. this code will now prevent any number of extensions to git and I'm not certain that that is intended. It's probably the case that this forbidden should be dropped or at least switchable.

[lafriks]

While I agree this needs to be refactored but as hotfix this seems to be good enough for now

[lafriks]

Closing in favor of #16706