-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix openidConnect source regression from #16544 #16759
Merged
zeripath
merged 4 commits into
go-gitea:main
from
zeripath:fix-regression-in-16544-openidconnect
Aug 22, 2021
Merged
Fix openidConnect source regression from #16544 #16759
zeripath
merged 4 commits into
go-gitea:main
from
zeripath:fix-regression-in-16544-openidconnect
Aug 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately there is bug in go-gitea#16544 meaning that openid connects aren't being matched properly as the capitalisation in that PR is incorrect. This PR changes the capitalisation back to what is expected. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
issue/regression
Indicates a previously functioning feature or behavior that has broken or regressed after a change
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
labels
Aug 20, 2021
techknowlogick
approved these changes
Aug 20, 2021
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Aug 20, 2021
Codecov Report
@@ Coverage Diff @@
## main #16759 +/- ##
==========================================
+ Coverage 45.49% 45.51% +0.01%
==========================================
Files 762 762
Lines 85939 85939
==========================================
+ Hits 39099 39115 +16
+ Misses 40527 40516 -11
+ Partials 6313 6308 -5
Continue to review full report at Codecov.
|
KN4CK3R
approved these changes
Aug 22, 2021
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Aug 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
issue/regression
Indicates a previously functioning feature or behavior that has broken or regressed after a change
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately there is bug in #16544 meaning that openid connects aren't
being matched properly as the capitalisation in that PR is incorrect.
This PR changes the capitalisation back to what is expected.
Signed-off-by: Andrew Thornton art27@cantab.net