Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doctor dbconsistency check for release and attachment #16978

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Add doctor dbconsistency check for release and attachment #16978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bf54aa
Add doctor dbconsistency check for release and attachment
lunny Sep 7, 2021
6796fab
Merge branch 'main' into lunny/doctor_attachment
6543 Sep 9, 2021
b6859ce
Merge branch 'main' into lunny/doctor_attachment
zeripath Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions models/attachment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,3 +272,16 @@ func IterateAttachment(f func(attach *Attachment) error) error {
}
}
}

// CountOrphanedAttachments returns the number of bad attachments
func CountOrphanedAttachments() (int64, error) {
return x.Where("(issue_id > 0 and issue_id not in (select id from issue)) or (release_id > 0 and release_id not in (select id from `release`))").
Count(new(Attachment))
}

// DeleteOrphanedAttachments delete all bad attachments
func DeleteOrphanedAttachments() error {
_, err := x.Where("(issue_id > 0 and issue_id not in (select id from issue)) or (release_id > 0 and release_id not in (select id from `release`))").
Delete(new(Attachment))
return err
}
36 changes: 36 additions & 0 deletions modules/doctor/dbconsistency.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,24 @@ func checkDBConsistency(logger log.Logger, autofix bool) error {
}
}

// find releases without existing repository
count, err = models.CountOrphanedObjects("release", "repository", "release.repo_id=repository.id")
if err != nil {
logger.Critical("Error: %v whilst counting orphaned objects", err)
return err
}
if count > 0 {
if autofix {
if err = models.DeleteOrphanedObjects("release", "repository", "release.repo_id=repository.id"); err != nil {
logger.Critical("Error: %v whilst deleting orphaned objects", err)
return err
}
logger.Info("%d releases without existing repository deleted", count)
} else {
logger.Warn("%d releases without existing repository", count)
}
}

// find pulls without existing issues
count, err = models.CountOrphanedObjects("pull_request", "issue", "pull_request.issue_id=issue.id")
if err != nil {
Expand Down Expand Up @@ -110,6 +128,24 @@ func checkDBConsistency(logger log.Logger, autofix bool) error {
}
}

// find attachments without existing issues or releases
count, err = models.CountOrphanedAttachments()
if err != nil {
logger.Critical("Error: %v whilst counting orphaned objects", err)
return err
}
if count > 0 {
if autofix {
if err = models.DeleteOrphanedAttachments(); err != nil {
logger.Critical("Error: %v whilst deleting orphaned objects", err)
return err
}
logger.Info("%d attachments without existing issue or release deleted", count)
} else {
logger.Warn("%d attachments without existing issue or release", count)
}
}

// find null archived repositories
count, err = models.CountNullArchivedRepository()
if err != nil {
Expand Down