-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge endpoints for pull diff/patch #17104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
modifies/api
This PR adds API routes or modifies them
pr/breaking
Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it!
type/docs
This PR mainly updates/creates documentation
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
labels
Sep 20, 2021
Codecov Report
@@ Coverage Diff @@
## main #17104 +/- ##
==========================================
+ Coverage 45.30% 45.32% +0.01%
==========================================
Files 773 773
Lines 86873 86873
==========================================
+ Hits 39356 39371 +15
+ Misses 41152 41140 -12
+ Partials 6365 6362 -3
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Sep 20, 2021
6543
approved these changes
Sep 20, 2021
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Sep 20, 2021
lafriks
approved these changes
Sep 21, 2021
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Sep 21, 2021
🚀 |
noerw
removed
the
pr/breaking
Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it!
label
Jan 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/api
This PR adds API routes or modifies them
type/docs
This PR mainly updates/creates documentation
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #17095 (comment), this merges the two API endpoints for the PR diff/patch in to one, like for the commits.