Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests hostkeys (#17786) #17787

Closed
wants to merge 4 commits into from
Closed

Fix tests hostkeys (#17786) #17787

wants to merge 4 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 23, 2021

Backport (#17786)

allow ssh-rsa as hostkey algorithm

@6543 6543 added this to the 1.15.7 milestone Nov 23, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 23, 2021
@6543 6543 modified the milestones: 1.15.7, 1.15.8 Nov 25, 2021
@lunny
Copy link
Member

lunny commented Dec 19, 2021

tests failure may related.

@6543
Copy link
Member Author

6543 commented Dec 19, 2021

well yes see long conversation at #17786

two options:

  1. move it ti next v1.15.x until we have new ssh version in our test environment
  2. close this for now and only track this issue at Fix tests hostkeys #17786

@zeripath
Copy link
Contributor

For this PR to work we'd need to detect which version of ssh was in use.

@zeripath zeripath modified the milestones: 1.15.8, 1.15.9 Dec 19, 2021
@6543 6543 modified the milestones: 1.15.9, 1.15.10 Dec 30, 2021
@6543
Copy link
Member Author

6543 commented Jan 4, 2022

ok I'll close this to only track things at #17786

@6543 6543 closed this Jan 4, 2022
@6543 6543 deleted the fix-tests-ssh-hostkeys branch January 4, 2022 01:22
@6543 6543 removed this from the 1.15.10 milestone Jan 4, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/bug type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @lunny @zeripath @silverwind @GiteaBot