Fix code formating #17829
Closed
Fix code formating #17829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"make fmt" always want to change this, so better merge it so we do not introduce unrelated changes when running "make fmt" later
|
So "make fmt" didn't catch this formatting error, but "make lint" did. I guess I stumbled on something weird. I am closing the PR, as I guess I surely did something wrong. |
GiteaBot
added
the
lgtm/need 2
|
I think it comes from this PR: I just wrote our own formatter, used imports come first, dummy imports ( ps: these two formats are all valid for lint |
|
Oh, the lint problem is caused by a space, I think we can re-open this PR |
|
So seems I can't reopen the PR, so I have to recreate it. "make fmt" had to be run twice to correct the issue. |
Merged
|
Thanks. That's really a rare case 😂 I will improve our code formatter later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"make fmt" always want to change this, so better merge it so
we do not introduce unrelated changes when running "make fmt" later