Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EasyMDE image paste bug during refactoring #18207

Merged
merged 3 commits into from
Jan 8, 2022
Merged

Fix EasyMDE image paste bug during refactoring #18207

merged 3 commits into from
Jan 8, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 8, 2022 •
edited
Loading

The refactoring #18069 introduced async EasyMDE creation.

Then the Image Paste feature must be called after the await createCommentEasyMDE, otherwise sometimes the Image Paste can not work.

@wxiaoguang wxiaoguang added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels Jan 8, 2022
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Jan 8, 2022
@codecov-commenter

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 8, 2022
zeripath
zeripath approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this part of the problem of not ensuring every async is awaited...

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 8, 2022
@wxiaoguang
Copy link
Contributor Author

I guess this part of the problem of not ensuring every async is awaited...

Yep, and that's somehow related to the current frontend framework, we haven't managed the dependencies between components (modules), sometimes an async should be awaited while sometimes no need to await. And I will pay more attention to frontend system.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 8, 2022
@wxiaoguang wxiaoguang merged commit 70d7475 into go-gitea:main Jan 8, 2022
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 8, 2022
@wxiaoguang wxiaoguang deleted the fix-easymde-paste branch January 8, 2022 13:33
zjjhot pushed a commit to zjjhot/gitea that referenced this pull request Jan 8, 2022
Merge branch 'main' of https://github.com/go-gitea/gitea
eeef0f3 
* 'main' of https://github.com/go-gitea/gitea:
  Fix EasyMDE image paste bug during refactoring (go-gitea#18207)
  Sort locales according to their names (go-gitea#18211)
  Restore setting of ctx.Repo.Mirror (go-gitea#18205)
  [skip ci] Updated translations via Crowdin
  Show OAuth callback error message (go-gitea#18185)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@wxiaoguang
Fix EasyMDE image paste bug during refactoring (go-gitea#18207)
a0f6929
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @codecov-commenter @lunny @zeripath @GiteaBot