Disable unnecessary SSH elements #18482

pboguslawski · 2022-01-31T13:27:28Z

This mod fixes disabling unnecessary SSH elements.

Related: #13129
Author-Change-Id: IB#1115249

This mod fixes disabling unnecessary SSH elements. Related: go-gitea#13129 Author-Change-Id: IB#1115249

Gusted · 2022-01-31T20:17:20Z

options/locale/locale_en-US.ini

@@ -517,7 +517,7 @@ appearance = Appearance
 password = Password
 security = Security
 avatar = Avatar
-ssh_gpg_keys = SSH / GPG Keys
+keys = Keys


IMO: I think Keys is too vague to be a navbar item.

I suspect that we might need to have a GPG Keys menu option if SSH is absolutely disabled.

Menu item should not contain technology name (SSH, GPG, etc.) because disabled items should be removed from page (clean UI should not contain stuff user don't use). It should also be short and clear. "Keys" are fine IHMO and not more vague than other existing items there. Propose better name if you can't accept simple "Keys".

If you check GitHub's UI and Gitlab's UI you'll find that the technology name is included in the tab name.

We have to include the technology type to disambiguate the type of keys.

There are authentication keys - eg. Yubikeys which are not configured on this tab. If you call it Keys then this will become confusing.

If you check GitHub's UI and Gitlab's UI you'll find that the technology name is included in the tab name.

Gitea may have cleaner UI :)

Propose better name if you can't accept simple "Keys" (avoid leaving unnecessary items like SSH words when SSH is disabled in config).

There are authentication keys - eg. Yubikeys which are not configured on this tab.

SSH keys are also authentication keys. Consider merging all this auth/sign/token stuff in one page like "Security" in the future. Or maybe move all this stuff to existing Account page if space allows.

Sorry didn't noticed GPG Keys proposal - will extend mod with this. Still consider merging all this auth/sign/token stuff in one page in user settings in the future.

Gusted · 2022-01-31T20:25:55Z

templates/user/settings/keys_principal.tmpl

 			<div class="ui blue tiny show-panel button" data-panel="#add-ssh-principal-panel">{{.i18n.Tr "settings.add_new_principal"}}</div>
-		{{else}}
-			<div class="ui blue tiny button disabled">{{.i18n.Tr "settings.ssh_disabled"}}</div>


I think for the user's information these should be kept.

There should be no unnecessary items in UI present to make it as clean as possible. If owner disables SSH in the application there is no point in leaving SSH items in UI.

From how I see it, if I happens to be on some gitea instance and I didn't saw such menu(and didn't had the knowledge it could be disabled) I would open a bug report that this menu is not present, I think it's safe to inform the users that it isn't enabled on the instance.

SSH is de-facto standard for Git operations nowadays and is expected to be supported universally everywhere. User should most definitely be informed that SSH is not available.

I would open a bug report that this menu is not present,

Reading system manual should be enough.

There should be no unnecessary items in UI present to make it as clean as possible. We prefer to give users clean UI without unnecessary information noise and will hide all SSH stuff. Feel free to close this PR if you don't like it.

and is expected to be supported universally everywhere

We don't expect using git over SSH so the above is false :).

We don't expect using git over SSH so the above is false :).

Your singular needs do not represent the bigger picture. Please understand that Gitea is a project aimed at far bigger audience - for a feature to be added it should take into consideration that fact. I see no bigger issues with this PR other than the mentioned notification about disabled SSH being removed.

Your singular needs[...]

We only push PRs that may be valuable for bigger audience. Clean UI is IHMO. As mentioned above - fell free to close this PR if you don't like it.

zeripath

We're gonna need to reindent these files I think

zeripath · 2022-01-31T20:44:37Z

options/locale/locale_en-US.ini

@@ -517,7 +517,7 @@ appearance = Appearance
 password = Password
 security = Security
 avatar = Avatar
-ssh_gpg_keys = SSH / GPG Keys
+keys = Keys


I suspect that we might need to have a GPG Keys menu option if SSH is absolutely disabled.

pboguslawski · 2022-02-01T08:07:21Z

I suspect that we might need to have a GPG Keys menu option if SSH is absolutely disabled.

If SSH is disabled, menu GPG Keys with GPG keys is still present after this mod is applied. If SSH is enabled, both SSH and GPG keys are present under SSH / GPG Keys menu.

Fixes: a82f4ee Related: go-gitea#18482 Author-Change-Id: IB#1115249

stale · 2022-04-18T20:06:57Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

wxiaoguang · 2023-05-10T07:17:37Z

It has been stale for a long time, I think it could be closed.

ps: I also agree that usually it should avoid "hiding" UI details, which makes the UI fragile and difficult to test.

A whole page could be hidden totally if a feature is disabled, but hiding UI elements again and again seems whack-a-mole game.

Disable unnecessary SSH elements

a82f4ee

This mod fixes disabling unnecessary SSH elements. Related: go-gitea#13129 Author-Change-Id: IB#1115249

pboguslawski mentioned this pull request Jan 31, 2022

Disabling application elements fixed #13129

Closed

Gusted reviewed Jan 31, 2022

View reviewed changes

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 31, 2022

zeripath reviewed Jan 31, 2022

View reviewed changes

GPG word restored in menu

b234641

Fixes: a82f4ee Related: go-gitea#18482 Author-Change-Id: IB#1115249

techknowlogick added this to the 1.17.0 milestone Feb 2, 2022

stale bot added the issue/stale label Apr 18, 2022

lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Apr 19, 2022

stale bot removed the issue/stale label Apr 19, 2022

techknowlogick modified the milestones: 1.17.0, 1.18.0 Jun 8, 2022

lunny modified the milestones: 1.18.0, 1.19.0 Oct 17, 2022

lunny modified the milestones: 1.19.0, 1.20.0 Feb 3, 2023

wxiaoguang closed this May 10, 2023

GiteaBot removed this from the 1.20.0 milestone May 10, 2023

go-gitea locked as resolved and limited conversation to collaborators Aug 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable unnecessary SSH elements #18482

Disable unnecessary SSH elements #18482

pboguslawski commented Jan 31, 2022

Gusted Jan 31, 2022

zeripath Jan 31, 2022

pboguslawski Feb 1, 2022 •

edited

Loading

zeripath Feb 1, 2022

pboguslawski Feb 1, 2022 •

edited

Loading

pboguslawski Feb 1, 2022

pboguslawski Feb 1, 2022

Gusted Jan 31, 2022

pboguslawski Feb 1, 2022 •

edited

Loading

Gusted Feb 1, 2022

CirnoT Feb 1, 2022

pboguslawski Feb 2, 2022

CirnoT Feb 2, 2022

pboguslawski Feb 2, 2022 •

edited

Loading

zeripath left a comment

zeripath Jan 31, 2022

pboguslawski commented Feb 1, 2022 •

edited

Loading

stale bot commented Apr 18, 2022

wxiaoguang commented May 10, 2023

Disable unnecessary SSH elements #18482

Disable unnecessary SSH elements #18482

Conversation

pboguslawski commented Jan 31, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pboguslawski Feb 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pboguslawski Feb 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pboguslawski Feb 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pboguslawski Feb 2, 2022 • edited Loading

Choose a reason for hiding this comment

zeripath left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pboguslawski commented Feb 1, 2022 • edited Loading

stale bot commented Apr 18, 2022

wxiaoguang commented May 10, 2023

pboguslawski Feb 1, 2022 •

edited

Loading

pboguslawski Feb 1, 2022 •

edited

Loading

pboguslawski Feb 1, 2022 •

edited

Loading

pboguslawski Feb 2, 2022 •

edited

Loading

pboguslawski commented Feb 1, 2022 •

edited

Loading