-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make docker gitea/gitea:v1.16-dev etc refer to the latest build on that branch (#18551) #18569
Merged
zeripath
merged 3 commits into
go-gitea:release/v1.16
from
zeripath:backport-18551-v1.16
Feb 3, 2022
Merged
Make docker gitea/gitea:v1.16-dev etc refer to the latest build on that branch (#18551) #18569
zeripath
merged 3 commits into
go-gitea:release/v1.16
from
zeripath:backport-18551-v1.16
Feb 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at branch (go-gitea#18551) Backport go-gitea#18551 (Backporting this will enable this target to create 1.16-dev) One of the problems with our current docker tagging is that although we have strict version tags, latest and dev we do not have a way for docker users to track the current release branch. This PR simply suggests that we use the 1.x-dev tag for these and we build and push these. This will give users who want or need unreleased bug fixes the option of tracking the pre-release version instead of simply jumping to dev. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zeripath
added
the
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
label
Feb 3, 2022
KN4CK3R
approved these changes
Feb 3, 2022
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Feb 3, 2022
zeripath
commented
Feb 3, 2022
Also contains backport for #18573 |
6543
approved these changes
Feb 3, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 3, 2022
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 3, 2022
…at branch (go-gitea#18551) (go-gitea#18569) Backport go-gitea#18551 One of the problems with our current docker tagging is that although we have strict version tags, latest and dev we do not have a way for docker users to track the current release branch. This PR simply suggests that we use the 1.x-dev tag for these and we build and push these. This will give users who want or need unreleased bug fixes the option of tracking the pre-release version instead of simply jumping to dev. However, there is a problem with go-gitea#18551/go-gitea#18569 whereby the manifest is not properly uploading. Therefore this PR adds in some debug logging in order to get this to debug things. Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
pushed a commit
that referenced
this pull request
Feb 3, 2022
…at branch (#18551) (#18569) (#18575) Backport #18551 One of the problems with our current docker tagging is that although we have strict version tags, latest and dev we do not have a way for docker users to track the current release branch. This PR simply suggests that we use the 1.x-dev tag for these and we build and push these. This will give users who want or need unreleased bug fixes the option of tracking the pre-release version instead of simply jumping to dev. However, there is a problem with #18551/#18569 whereby the manifest is not properly uploading. Therefore this PR adds in some debug logging in order to get this to debug things. Signed-off-by: Andrew Thornton <art27@cantab.net>
delvh
added
topic/distribution
This PR changes something about the packaging of Gitea
and removed
theme/docker
labels
Oct 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
topic/distribution
This PR changes something about the packaging of Gitea
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #18551
(Backporting this will enable drone to create the 1.16-dev docker tag)
One of the problems with our current docker tagging is that although we
have strict version tags, latest and dev we do not have a way for docker
users to track the current release branch. This PR simply suggests that
we use the 1.x-dev tag for these and we build and push these. This will
give users who want or need unreleased bug fixes the option of tracking
the pre-release version instead of simply jumping to dev.
Signed-off-by: Andrew Thornton art27@cantab.net
Co-authored-by: KN4CK3R admin@oldschoolhack.me
Co-authored-by: Lunny Xiao xiaolunwen@gmail.com