Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure commit-statuses box is sized correctly in headers (#18538) #18606

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 4, 2022

Backport #18538
Backport #18605

  • Ensure commit-statuses box is sized correctly in headers

When viewing commits as commits the commit-status box will be fixed at 30px in height
due to being forced to be this size by a fomantic selector. This PR simply adds a
few more selectors to force this to have height auto.

Fix #18498

Signed-off-by: Andrew Thornton art27@cantab.net
Co-authored-by: wxiaoguang wxiaoguang@gmail.com

zeripath and others added 2 commits February 4, 2022 15:54
)

Backport go-gitea#18538
Backport go-gitea#18605

* Ensure commit-statuses box is sized correctly in headers

When viewing commits as commits the commit-status box will be fixed at 30px in height
due to being forced to be this size by a fomantic selector. This PR simply adds a
few more selectors to force this to have height auto.

Fix go-gitea#18498

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Somehow a spurious space sneaked in to go-gitea#18538
this PR simply removes it.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.16.1 milestone Feb 4, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 4, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 4, 2022
@6543 6543 merged commit 69b7776 into go-gitea:release/v1.16 Feb 4, 2022
@zeripath zeripath deleted the backport-18538-v1.16 branch February 4, 2022 17:39
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants