-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated SSH ciphers from default #18697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a better and more curated list of Ciphers and KeyExchanges, these roughly follows OpenSSH's default. - Remove some cryptography values which were deprecated.
Gusted
added
pr/breaking
Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it!
topic/security
Something leaks user information or is otherwise vulnerable. Should be fixed!
labels
Feb 9, 2022
techknowlogick
changed the title
Update SSH Server crypto settings
Remove deprecated SSH ciphers from default
Feb 10, 2022
zeripath
approved these changes
Feb 10, 2022
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Feb 10, 2022
lunny
approved these changes
Feb 10, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 10, 2022
6543
approved these changes
Feb 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #18697 +/- ##
=======================================
Coverage ? 46.44%
=======================================
Files ? 851
Lines ? 121925
Branches ? 0
=======================================
Hits ? 56628
Misses ? 58418
Partials ? 6879
Continue to review full report at Codecov.
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 11, 2022
* giteaofficial/main: Prevent double encoding of branch names in delete branch (go-gitea#18714) [skip ci] Updated translations via Crowdin Attempt to improve docs (yet again) (go-gitea#18687) Make the proformas clearer that we need DEBUG logs (go-gitea#18700) Update SSH Server crypto settings (go-gitea#18697) Fix bug for version update hint (go-gitea#18701)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
- Use a better and more curated list of Ciphers and KeyExchanges, these roughly follows OpenSSH's default. - Remove some cryptography values which were deprecated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
pr/breaking
Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it!
topic/security
Something leaks user information or is otherwise vulnerable. Should be fixed!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm removing some cryptography values which I'd really don't like to set as default value, so it's able that special older devices will have trouble SSH'n to the server:
p
(as in mod p, see a example), the prime is defined here and is 1024-bit long. While 512-bit primes have been attacked and has caused real-world harm it's better to remove to this completely as well, not secure, not safe and definitely not should be preferred.