Update object repo with the migrated repository (#18684) #18726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating a repository (from GitHub) using the API (**POST** `repos/migrate`), the Code Indexer is not updated. Searching in the user interface will not return any results. When migrating the same repository using **+/New Migration** in the web interface, the search index is updated and searching works as expected. Caused by the fact that object `repo` is never updated with the migrated repo so `setting.Indexer.RepoIndexerEnabled && !repo.IsEmpty` in `modules/notification/indexer/indexer.go:NotifyMigrateRepository` always evaluates to `false`. Tested with gitea:1.16.1, MariaDB:10, Breve in `Run Mode: Dev`.
silverwind
approved these changes
Feb 11, 2022
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
Feb 11, 2022
GiteaBot
added
lgtm/done
zeripath
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #18684
When migrating a repository (from GitHub) using the API (POST
repos/migrate), the Code Indexer is not updated. Searching in the user interface will not return any results.When migrating the same repository using +/New Migration in the web interface, the search index is updated and searching works as expected.
Caused by the fact that object
repois never updated with the migrated repo sosetting.Indexer.RepoIndexerEnabled && !repo.IsEmptyinmodules/notification/indexer/indexer.go:NotifyMigrateRepositoryalways evaluates tofalse.Tested with gitea:1.16.1, MariaDB:10, Breve in
Run Mode: Dev.