Attempt to fix the webauthn migration again - part 3 (#18770) #18771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaDB now asserts that 408 characters is too long for a VARCHAR(410) I have no words. See go-gitea#18756 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
backport-varchar-410-is-not-enough
branch
from
5afd9fc
to
fdc245f
Compare
zeripath
changed the title
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
commented
Feb 15, 2022
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
commented
Feb 15, 2022
fnetX
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
I tested this backport on our data, and I can at least confirm that the resulting data (id, credential_id) in webauthn_credential is equal to what the previous migration was supposed to do :)
I'll probably check later if my key is accepted, but I'll first need to learn how the access the web interface via multiple agent forwarded ssh connections ...
fnetX
reviewed
Feb 15, 2022
Signed-off-by: Andrew Thornton <art27@cantab.net>
…char-410-is-not-enough
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Gusted
approved these changes
Feb 16, 2022
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Feb 16, 2022
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #18770
v208.go is seriously broken as it misses an ID() check. We need to no-op and remigrate all of the u2f keys.
See #18756
Signed-off-by: Andrew Thornton art27@cantab.net