redirect .wiki/* ui link to /wiki

[a1012112796]

fix #18590

[silverwind]

This would break on https://foo.wiki/user/repo.wiki?query=foo.wiki. Would at least include the repo name in the replacement, or properly parse the URL apart and join it again after replacement on the path.

[zeripath]

@wxiaoguang @a1012112796 I've changed the redirect code to more closely match

gitea/modules/context/context.go

Lines 125 to 143 in 3f280f8

	// RedirectToUser redirect to a differently-named user
	func RedirectToUser(ctx *Context, userName string, redirectUserID int64) {
	user, err := user_model.GetUserByID(redirectUserID)
	if err != nil {
	ctx.ServerError("GetUserByID", err)
	return
	}
	redirectPath := strings.Replace(
	ctx.Req.URL.EscapedPath(),
	url.PathEscape(userName),
	url.PathEscape(user.Name),
	1,
	)
	if ctx.Req.URL.RawQuery != "" {
	redirectPath += "?" + ctx.Req.URL.RawQuery
	}
	ctx.Redirect(path.Join(setting.AppSubURL, redirectPath), http.StatusTemporaryRedirect)
	}

This now works on suburl mounted giteas too.

[wxiaoguang]

It seems correct.

I have a small question that could we just use redirectPath := url.PathEscape(userName)+"/"+url.PathEscape(mainRepoName)+"/wiki" + what_ever? Then we do not need the replace.

Maybe like this?

	// redirect link to from "/org/repo.wiki" to "/org/repo/wiki"
	if strings.HasSuffix(repoName, ".wiki") {
		// ctx.Req.URL.Path does not have the preceding appSubURL - any redirect must have this added
		// Now we happen to know that all of our paths are: /:username/:reponame/whatever_else
		pathFields := strings.SplitN(ctx.Req.URL.EscapedPath(), "/", 4)
		redirectUri := "/" + pathFields[1] + "/" + strings.TrimSuffix(pathFields[2], ".wiki") + "/wiki"
		if len(pathFields) == 4 {
			redirectUri += "/" + pathFields[3]
		}
		if ctx.Req.URL.RawQuery != "" {
			redirectUri += "?" + ctx.Req.URL.RawQuery
		}
		ctx.Redirect(path.Join(setting.AppSubURL, redirectUri))
		return
	}

[zeripath]

So I initially considered that but decided that it would be better to keep the same code style as the RedirectToUser.

[wxiaoguang]

Either is fine to me, already approved. (while personally I would choose a straight way if it's better than the old method)

[zeripath]

make lgtm work

[zeripath]

Either is fine to me, already approved. (while personally I would choose a straight way if it's better than the old method)

TBH I didn't feel that either was much better. They're both making pretty bad assumptions about the structure of the urls. Ideally we need some way of getting chi to do the replacement instead - chi's router is the thing that knows which thing is matching the :reponame parameter here.

[wxiaoguang]

Maybe it's worthy to introduce a function RedirectToOrgRepo(org, repo, extra, query) to replace RedirectToUser and this code.