upgrade postgres reference to 14 in docs #19416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuhrysteve
changed the title
fuhrysteve
changed the title
techknowlogick
approved these changes
Apr 16, 2022
GiteaBot
added
the
lgtm/need 1
techknowlogick
added
type/docs
delvh
approved these changes
Apr 16, 2022
| @@ -147,7 +147,7 @@ services: | |||
| + - db | |||
| + | |||
| + db: | |||
| + image: postgres:13 | |||
| + image: postgres:14 | |||
There was a problem hiding this comment.
Suggested change
| + image: postgres:14 | |
| + image: postgres:latest |
| @@ -187,7 +187,7 @@ services: | |||
| + - db | |||
| + | |||
| + db: | |||
| + image: postgres:13 | |||
| + image: postgres:14 | |||
There was a problem hiding this comment.
Suggested change
| + image: postgres:14 | |
| + image: postgres:latest |
| @@ -172,7 +172,7 @@ services: | |||
| + - db | |||
| + | |||
| + db: | |||
| + image: postgres:13 | |||
| + image: postgres:14 | |||
There was a problem hiding this comment.
Suggested change
| + image: postgres:14 | |
| + image: postgres:latest |
| @@ -36,7 +36,7 @@ TEST_MYSQL_HOST=localhost:3306 TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root T | |||
| ## 如何使用 pgsql 数据库进行集成测试 | |||
| 同上，首先在 docker 容器里部署一个 pgsql 数据库 | |||
| ``` | |||
| docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:13 #(just ctrl-c to stop db and clean the container) | |||
| docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:14 #(just ctrl-c to stop db and clean the container) | |||
There was a problem hiding this comment.
Suggested change
| docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:14 #(just ctrl-c to stop db and clean the container) | |
| docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:latest #(just ctrl-c to stop db and clean the container) |
There was a problem hiding this comment.
I’m generally always hesitant to document “latest” as the tag someone should use, as it can change meaning without expectation
GiteaBot
added
the
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 18, 2022
* giteaofficial/main: [skip ci] Updated translations via Crowdin [skip ci] Updated licenses and gitignores upgrade postgres refrence to 14 (go-gitea#19416)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the reference in the docs to PostgreSQL 14