Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fetch Mirror when it's migrating #19588

Merged
merged 3 commits into from
May 3, 2022
Merged

Don't fetch Mirror when it's migrating #19588

merged 3 commits into from
May 3, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented May 2, 2022

Don't fetch Mirror when it's migrating
77b38a8 
- When a repository is still being migrated, don't try to fetch the
Mirror from the database. Instead skip it. This allows to visit
repositories that are still being migrated and were configured to be
mirrored.
- Resolves go-gitea#19585
- Regression: go-gitea#19295
@Gusted Gusted added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed type/bug labels May 2, 2022
@Gusted Gusted added this to the 1.17.0 milestone May 2, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@438646e). Click here to learn what that means.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #19588   +/-   ##
=======================================
  Coverage        ?   47.38%           
=======================================
  Files           ?      952           
  Lines           ?   132673           
  Branches        ?        0           
=======================================
  Hits            ?    62869           
  Misses          ?    62222           
  Partials        ?     7582
Impacted Files Coverage Δ
models/task.go 35.29% <0.00%> (ø)
modules/context/repo.go 51.30% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438646e...77b38a8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 2, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 3, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2022
@lafriks lafriks merged commit 982b726 into go-gitea:main May 3, 2022
@Gusted Gusted deleted the dont-fetch-mirror branch May 3, 2022 14:15
Gusted pushed a commit to Gusted/gitea that referenced this pull request May 3, 2022
Only check for non-finished migrating task
5799cd9 
- Only check if a non-finished migrating task exists for a mirror before
fetching the mirror details from the database.
- Resolves go-gitea#19600
- Regression: go-gitea#19588
@Gusted Gusted mentioned this pull request May 3, 2022
Merged
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 4, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5b8948d 
* giteaofficial/main:
  Fix broken TR on cherrypick page (go-gitea#19599)
  Use correct context in `routers/web` (go-gitea#19597)
  Use for a repo action one database transaction (go-gitea#19576)
  Only set CanColorStdout / CanColorStderr to true if the stdout/stderr is a terminal (go-gitea#19581)
  Don't fetch Mirror when it's migrating (go-gitea#19588)
  Move user password verification after checking his groups on ldap auth (go-gitea#19587)
6543 pushed a commit that referenced this pull request May 4, 2022
Only check for non-finished migrating task (#19601)
3114cd3 
* Only check for non-finished migrating task

- Only check if a non-finished migrating task exists for a mirror before
fetching the mirror details from the database.
- Resolves #19600
- Regression: #19588

* Clarify function
@lunny lunny mentioned this pull request Jun 13, 2022
Merged
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@wxiaoguang @AbdulrhmnGhanem
Don't fetch Mirror when it's migrating (go-gitea#19588)
61a8b48 
- When a repository is still being migrated, don't try to fetch the
Mirror from the database. Instead skip it. This allows to visit
repositories that are still being migrated and were configured to be
mirrored.
- Resolves go-gitea#19585
- Regression: go-gitea#19295

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@AbdulrhmnGhanem
Only check for non-finished migrating task (go-gitea#19601)
298f3ef 
* Only check for non-finished migrating task

- Only check if a non-finished migrating task exists for a mirror before
fetching the mirror details from the database.
- Resolves go-gitea#19600
- Regression: go-gitea#19588

* Clarify function
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

HTTP 500 on new migration.
7 participants
@Gusted @codecov-commenter @lunny @lafriks @a1012112796 @GiteaBot @wxiaoguang