-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hint to GNUPGHOME environment variable #20134
Conversation
With go-gitea#19732, the default location for the `.gnupg` folder has changed. To mitigate this breaking change, users can specify the home directory for gnupg via `$GNUPGHOME` environment variable to keep using their current location.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Trimmed the explicit new line as suggested. I was not sure whether an explicit line break would help the readability. |
CI failure seems unrelated. |
Agh! this is a problem. We shouldn't have set the repository root as the HOME directory. This is not an appropriate directory especially as usernames can start with |
I do not think it's a problem.
Directories starting with dot have special meaning, it's already a good practice across OS. |
This comment was marked as outdated.
This comment was marked as outdated.
Update: I over-thought something about the Git HOME problem. Since it's fine to use a newly created directory in Gitea's data directory, there will a PR for it Update: the PR: |
I guess #20114 makes the hint to that environment variable unrelated to 1.17 but still good to know for administrators. So I'll update this PR once the mentioned PR is done. |
Let's wait for Then the (put a blocked label here to prevent from accident merge) |
Codecov Report
@@ Coverage Diff @@
## main #20134 +/- ##
=======================================
Coverage ? 46.92%
=======================================
Files ? 975
Lines ? 134992
Branches ? 0
=======================================
Hits ? 63341
Misses ? 63889
Partials ? 7762 Continue to review full report at Codecov.
|
#20114 merged, please resolve the conflicts. |
Resolve conflicts
Conflicts resolved. |
make L-G-T-M work. |
* giteaofficial/main: [skip ci] Updated translations via Crowdin Vertical align avatar at middle (go-gitea#20302) Changed scroll to auto for some UI elements. (go-gitea#20294) Add hint to GNUPGHOME environment variable (go-gitea#20134) Refactor SSH init code, fix directory creation for TrustedUserCAKeys file (go-gitea#20299) [skip ci] Updated translations via Crowdin Use dedicated draft PR icon when possible (go-gitea#20303) Update goldmark (go-gitea#20300) Do not create empty ".ssh" directory when loading config (go-gitea#20289)
* Add hint for GNUPGHOME environment variable With go-gitea#19732, the default location for the `.gnupg` folder has changed. To mitigate this breaking change, users can specify the home directory for gnupg via `$GNUPGHOME` environment variable to keep using their current location. * Update docs/content/doc/advanced/signing.en-us.md Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: zeripath <art27@cantab.net>
With #19732, the default location for the
.gnupg
folder has changed. To mitigate this breaking change, users can specify the home directory for gnupg via$GNUPGHOME
environment variable to keep using their current location.