Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GO111MODULE #20221

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Remove GO111MODULE #20221

merged 1 commit into from
Jul 4, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jul 4, 2022

  • Given we use go1.18 for this and don't rely on the Go 1.11 modules behavior(we use the modern go run & go get which has the correct behavior by-default).

Remove GO111MODULE
920319c 
- Given we use go1.18 for this and don't rely on the Go 1.11 modules
behavior(we use the modern `go run` & `go get` which has the correct
behavior by-default).
@Gusted Gusted added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 4, 2022
@Gusted Gusted added this to the 1.18.0 milestone Jul 4, 2022
@Gusted Gusted added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jul 4, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 4, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 4, 2022
@lunny lunny merged commit f9b172d into go-gitea:main Jul 4, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 4, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
4e37ea7 
* upstream/main:
  Remove `GO111MODULE` (go-gitea#20221)
dineshsalunke pushed a commit to dineshsalunke/gitea that referenced this pull request Jul 9, 2022
@dineshsalunke
Remove GO111MODULE (go-gitea#20221)
d32ab45 
- Given we use go1.18 for this and don't rely on the Go 1.11 modules
behavior(we use the modern `go run` & `go get` which has the correct
behavior by-default).
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
Remove GO111MODULE (go-gitea#20221)
219e73e 
- Given we use go1.18 for this and don't rely on the Go 1.11 modules
behavior(we use the modern `go run` & `go get` which has the correct
behavior by-default).
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Gusted @lunny @techknowlogick @GiteaBot